-
Notifications
You must be signed in to change notification settings - Fork 95
[2854] extension property support #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2854] extension property support #264
Conversation
64a5eb5
to
ad632fc
Compare
Hi @alainosorio, Thank you for your contribution. Best regards, |
@alainosorio thank you once again for your contribution. We will be happy to merge this feature to External Task Client JS. Before doing so, documentation and test cases should be added as well. To extend the documentation, please add the new property to bottom of client.subscribeTo table: In case of any questions, please let us know. |
thanks @yanavasileva, will do and let you know |
ad632fc
to
ad149f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9689891
to
fba2fff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The subscription option to fetch extension properties is called
includeExtensionProperties
. - It is not possible to filter for extension properties – only no or all extension properties will be fetched.
fba2fff
to
0588d65
Compare
@alainosorio thank you for implementing the review hints. I will have a look and let you know once I merge the contribution as I believe we are on a good track with the PR already. |
Thanks! |
Related to camunda/camunda-bpm-platform/issues/2854 Closes PR #264
Hi @alainosorio, I adjusted the commit message according to our CONTRIBUTING guidelines and merged the code with 170192f. Best regards, |
Thanks! |
No description provided.