Skip to content

[2854] extension property support #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alainosorio
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2022

CLA assistant check
All committers have signed the CLA.

@alainosorio alainosorio force-pushed the feature/extension-property-support branch 2 times, most recently from 64a5eb5 to ad632fc Compare October 21, 2022 12:30
@alainosorio alainosorio changed the title extesion property support extension property support Oct 21, 2022
@yanavasileva yanavasileva self-assigned this Oct 24, 2022
@yanavasileva yanavasileva changed the title extension property support [2854]: extension property support Oct 24, 2022
@yanavasileva
Copy link
Member

yanavasileva commented Oct 24, 2022

Hi @alainosorio,

Thank you for your contribution.
I created camunda/camunda-bpm-platform/issues/2854 to track the progress of this request.
I will send the ticket for a decision, please keep in mind that it could take a while to get back to you because of other team responsibilities. Thank you for your patience in advance.
In case you would like to speed up the process, you can already think about adding tests and documentation in the contribution.

Best regards,
Yana

@yanavasileva yanavasileva removed their assignment Oct 24, 2022
@tmetzke tmetzke changed the title [2854]: extension property support extension property support Oct 26, 2022
@yanavasileva yanavasileva changed the title extension property support [2854] extension property support Oct 28, 2022
@yanavasileva
Copy link
Member

yanavasileva commented Oct 28, 2022

@alainosorio thank you once again for your contribution. We will be happy to merge this feature to External Task Client JS. Before doing so, documentation and test cases should be added as well.

To extend the documentation, please add the new property to bottom of client.subscribeTo table:
https://github.com/camunda/camunda-external-task-client-js/blob/master/docs/Client.md#clientsubscribetopic-options-handler
The existing test cases can be found here: https://github.com/camunda/camunda-external-task-client-js/blob/master/lib/Client.test.js#L209-L242

In case of any questions, please let us know.

@alainosorio
Copy link
Author

thanks @yanavasileva, will do and let you know

@alainosorio alainosorio force-pushed the feature/extension-property-support branch from ad632fc to ad149f1 Compare October 28, 2022 10:48
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alainosorio alainosorio force-pushed the feature/extension-property-support branch 3 times, most recently from 9689891 to fba2fff Compare November 1, 2022 09:09
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The subscription option to fetch extension properties is called includeExtensionProperties.
  • It is not possible to filter for extension properties – only no or all extension properties will be fetched.

@alainosorio alainosorio force-pushed the feature/extension-property-support branch from fba2fff to 0588d65 Compare November 3, 2022 08:23
@alainosorio alainosorio requested a review from tasso94 November 3, 2022 08:24
@tasso94 tasso94 requested review from yanavasileva and removed request for tasso94 November 3, 2022 09:07
@yanavasileva
Copy link
Member

@alainosorio thank you for implementing the review hints. I will have a look and let you know once I merge the contribution as I believe we are on a good track with the PR already.

@alainosorio
Copy link
Author

@alainosorio thank you for implementing the review hints. I will have a look and let you know once I merge the contribution as I believe we are on a good track with the PR already.

Thanks!

@yanavasileva
Copy link
Member

Hi @alainosorio,

I adjusted the commit message according to our CONTRIBUTING guidelines and merged the code with 170192f.
Thank you and I see you in your next contribution!

Best regards,
Yana

@alainosorio
Copy link
Author

Hi @alainosorio,

I adjusted the commit message according to our CONTRIBUTING guidelines and merged the code with 170192f. Thank you and I see you in your next contribution!

Best regards, Yana

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In External Task Client JS, I can fetch task extension properties
4 participants