Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): add console sm admin api #3799

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

urbanisierung
Copy link
Member

@urbanisierung urbanisierung commented May 14, 2024

Description

image

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@urbanisierung urbanisierung added the target:8.6 Issues included in the 8.6 release label May 14, 2024
Copy link
Contributor

github-actions bot commented May 14, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/apis-tools/console-sm-api/console-sm-api-authentication.md
  • docs/apis-tools/console-sm-api/console-sm-api-overview.md
  • docs/apis-tools/console-sm-api/sidebar-schema.js
  • docs/apis-tools/console-sm-api/specifications/console-sm-admin-api.info.mdx
  • docs/apis-tools/console-sm-api/specifications/get-clusters.api.mdx
  • docs/apis-tools/console-sm-api/specifications/get-usage-metrics.api.mdx
  • docs/apis-tools/console-sm-api/specifications/sidebar.js

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley christinaausley added the component:console Issues related with Console project label May 14, 2024
@urbanisierung
Copy link
Member Author

@theburi @ultraschuppi Here's the Docs PR for the Console SM Admin API. It uses the interactive API explorer generated from our OpenAPI spec. Please have a look and review the changes.

@urbanisierung
Copy link
Member Author

@pepopowitz iirc you've introduced the interactive API explorer to the docs. Can you please have a quick look if anything is missing in this PR? Thanks!

Copy link
Collaborator

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really fantastic!!!

I have a couple small blocking requests, and one non-blocking. Overall, it's great, and I want to thank you for following the patterns in place and practically nailing this implementation. It looks really good.

I'm also curious if you have feedback for me on what it takes to add a new API Explorer. Were there challenges along the way that seemed frustrating or unnecessary? Any opportunities for improvement you noticed?

@@ -46,15 +46,3 @@ function hackChangesetDescription() {
This ensures correct event emission for assignee changes.`,
});
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

api/console-sm/generation-strategy.js Outdated Show resolved Hide resolved
api/console-sm/console-sm-openapi.yaml Outdated Show resolved Hide resolved
@urbanisierung
Copy link
Member Author

I'm also curious if you have feedback for me on what it takes to add a new API Explorer. Were there challenges along the way that seemed frustrating or unnecessary? Any opportunities for improvement you noticed?

@pepopowitz I used a similar docusaurus plugin (maybe the same?) for one of my side project, so I already had same background knowledge what files to touch.

As a general improvement from my point of view:

  • Our OpenAPI lib creates a json file. haven't tried the plugin with a json as input. If it's not supported it would be nice to have a built-in way within the docs repo to use also json, for example with a json-to-yaml converter (also available as npm module)
  • What would be super cool: auto-fetching of OpenAPI spec instead of manually copying it. Our OpenAPI specs are (semi-) publicly available (via github or public url). The script could automatically fetch the latest content and update the docs.

Copy link
Collaborator

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ❤️ ❤️ ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:console Issues related with Console project target:8.6 Issues included in the 8.6 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants