-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(api): add console sm admin api #3799
base: main
Are you sure you want to change the base?
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@theburi @ultraschuppi Here's the Docs PR for the Console SM Admin API. It uses the interactive API explorer generated from our OpenAPI spec. Please have a look and review the changes. |
@pepopowitz iirc you've introduced the interactive API explorer to the docs. Can you please have a quick look if anything is missing in this PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really fantastic!!!
I have a couple small blocking requests, and one non-blocking. Overall, it's great, and I want to thank you for following the patterns in place and practically nailing this implementation. It looks really good.
I'm also curious if you have feedback for me on what it takes to add a new API Explorer. Were there challenges along the way that seemed frustrating or unnecessary? Any opportunities for improvement you noticed?
@@ -46,15 +46,3 @@ function hackChangesetDescription() { | |||
This ensures correct event emission for assignee changes.`, | |||
}); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up!
docs/apis-tools/console-sm-api/specifications/console-sm-admin-api.info.mdx
Outdated
Show resolved
Hide resolved
Good catch, thanks! Co-authored-by: Steven Hicks <steven.j.hicks@gmail.com>
@pepopowitz I used a similar docusaurus plugin (maybe the same?) for one of my side project, so I already had same background knowledge what files to touch. As a general improvement from my point of view:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ ❤️ ❤️ ❤️
Description
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).