may lychee third party link updates #3782
Conversation
christinaausley
added
kind/bug
|
@chillleader @RomanJRW looping you in as there are a few corrections for Connectors and Optimize, but let me know if you'd like another team member to take a look 👍 |
christinaausley
requested review from
RomanJRW,
YanaSegal and
chillleader
and removed request for
YanaSegal
|
CC @leiicamundi -- thanks again for opening the notes on Lychee. As a reminder, I have an hour on my calendar set aside each month to clean these up. |
docs/components/connectors/out-of-the-box-connectors/automation-anywhere.md
Show resolved
Hide resolved
|
Most of my questions about this PR stem from needing to fully understand how we can pick specific versions of 3rd party tech to reference in our docs. Theoretically, we can't pick "current" either unless we know the dependencies are kept up to date across all our supported versions. @christinaausley can you provide more context about how you chose the links with numbered versions in them? Are you matching it to the supported environments or dependencies pages? |
optimize/self-managed/optimize-deployment/configuration/system-configuration.md
Outdated
Show resolved
Hide resolved
| @@ -52,4 +52,4 @@ Apart from caching issues, there is the following list of known data update limi | |||
|
|
|||
| The configuration of Optimize allows you to define when the history cleanup is triggered using cron expression notation. However, the values are incorrectly interpreted in Optimize. For example, the `historyCleanup.cronTrigger` configuration has the default value `0 1 * * *`, which should be 01:00 AM every day. Unfortunately, a bug causes this to be interpreted as every hour. | |||
|
|
|||
| To fix this, use the Spring [cron expression notation](https://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/scheduling/support/CronSequenceGenerator.html). For instance, the default value for `historyCleanup.cronTrigger` would then be `0 0 1 * * *`. | |||
| To fix this, use the Spring [cron expression notation](https://docs.spring.io/spring-framework/docs/5.1.0.RELEASE/javadoc-api/org/springframework/scheduling/support/CronSequenceGenerator.html). For instance, the default value for `historyCleanup.cronTrigger` would then be `0 0 1 * * *`. | |||
There was a problem hiding this comment.
I am not going back to check which version of Spring we used on version 2.3... 😆
I would consider removing it here and in all the files below though, I don't see a big value including a link here
There was a problem hiding this comment.
There are 30 references of this across the docs -- would you prefer to remove the entire ### Misinterpreted cron expressions section? If so, do you feel users really need this context often, or it is rarely used?
If not, would you prefer to link to something like https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/scheduling/support/CronExpression.html?
There was a problem hiding this comment.
I don't have a good judgement on how often this is used, but I am sure it was probably added in the first place because it would have confused users at some point in time. I would be happy to change it to the docs link you suggested. This is the correct cron expression type and is not versioned docs. Thanks for the idea!
Description
May Lychee review for broken third-party links.
When should this change go live?
holdlabel or convert to draft PR)PR Checklist
/versioned_docsdirectory./docsdirectory (aka/next/).