Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connectors,sagemaker): introduce AWS SageMaker connector #3761

Merged
merged 4 commits into from
May 22, 2024

Conversation

igpetrov
Copy link
Contributor

@igpetrov igpetrov commented May 3, 2024

Description

This PR introduces documentation to the AWS SageMaker Connector.

Related to https://github.com/camunda/product-hub/issues/2325

When should this change go live?

This connector will be 'released' in 8.6 however, users would still be able to download it from the Connectors marketplace or repository. This means, that we have to keep it in /next/ until 8.6 stable release.

Otherwise, it is ready to be reviewed any time and merged just after @slolatte gives a sign-off as QA. Once sign-off is given, I will remove hold label and notify separately.

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@igpetrov igpetrov self-assigned this May 3, 2024
@igpetrov igpetrov added hold This issue is parked, do not merge. target:8.6 Issues included in the 8.6 release labels May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/connectors/out-of-the-box-connectors/amazon-sagemaker.md
  • docs/components/connectors/out-of-the-box-connectors/available-connectors-overview.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@igpetrov igpetrov added the component:connectors Issues related to the connectors project. label May 3, 2024
@igpetrov
Copy link
Contributor Author

igpetrov commented May 3, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?
These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.


Thank you, robot 🤖 . I need my changes only in /next/ until 8.6 stable release.

@igpetrov igpetrov removed the hold This issue is parked, do not merge. label May 21, 2024
@igpetrov
Copy link
Contributor Author

The connector passed QA successfully. The element template was submitted to Connectors Marketplace.

@crobbins215 - please give guidance whether we should merge this documentation. Please note, that the connector will be available officially with 8.6 but with the upcoming 8.6-alpha, customers can use it too.

@igpetrov
Copy link
Contributor Author

In this documentation, I included the docs in the /next/ section, so shouldn't cause much trouble but it's your call

@crobbins215
Copy link
Contributor

If its on the marketplace, which is should be soon, just reviewing, we should include it in the next docs

Oleksiivanov
Oleksiivanov previously approved these changes May 22, 2024
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really clean! Nice work.

@igpetrov igpetrov merged commit baddf89 into main May 22, 2024
6 checks passed
@igpetrov igpetrov deleted the sagemaker-docs branch May 22, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:connectors Issues related to the connectors project. target:8.6 Issues included in the 8.6 release
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants