-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(spring-zeebe-sdk): add missing spring sdk properties #3757
base: main
Are you sure you want to change the base?
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in versioned_docs/version-8.5/. You might want to duplicate these changes in docs/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@nicpuppa Is this still in |
Yes, we are adding more changes to the properties. I will ping you once is ready to be reviewed. Thanks @christinaausley 👍 |
Adding connection properties options for SaaS and SM Removing duplicate properties from getting-started.md
55fafb3
to
aa197e1
Compare
@christinaausley this is now ready for the review 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Description
Added missing Spring SDK properties
Added configuration for SaaS and SM cluster connections
closes: #3709
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).