Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch-exporter: Add link to index templates #3743

Merged
merged 6 commits into from
May 20, 2024

Conversation

falko
Copy link
Member

@falko falko commented Apr 30, 2024

It took me quite a while to dig the index templates out of the source based on the given hint. So, let's add the actual link and also point out that "this module" actually means the exporter source code: https://github.com/camunda/zeebe/tree/main/zeebe/exporters/elasticsearch-exporter/src/main/resources

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

It took me quite a while to dig the index templates out of the source based on the given hint. So, let's add the actual link and also point out that "this module" actually means the exporter source code: https://github.com/camunda/zeebe/tree/main/zeebe/exporters/elasticsearch-exporter/src/main/resources
Copy link
Contributor

github-actions bot commented Apr 30, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley christinaausley added component:zeebe Issues related with Zeebe project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Apr 30, 2024
@falko
Copy link
Member Author

falko commented Apr 30, 2024

@christinaausley I don't have more time to work on this. Primarily, I wanted to report the documentation issue. Could your team please finish the versioned docs? This may also need special attention, when new releases come out.

@christinaausley
Copy link
Contributor

@falko I can take this from here, thanks!

Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of those cases where we need to link to the version-specific URL. @npepinpe do you have any recommendations? I was having trouble finding a stable branch for 8.4 or the right tagged version.

Similar to my conversation on another PR - #3795 (comment)

@falko
Copy link
Member Author

falko commented May 13, 2024

@npepinpe
Copy link
Member

npepinpe commented May 13, 2024

Yes, every supported version has a stable branch (e.g. stable/8.4, stable/8.5). However, once the version is not supported anymore, we remove this. For the docs, we seem to keep a copy of the unsupported versions, so the links would become broken eventually. As an alternative, using the tag would work better, e.g.

And so on.

The downside here is:

  1. main always points to latest, so on every release we need to update those links to point to the new tag.
  2. The tags point to specific patch versions. Though, I don't expect us to change these things much between patches, it's not impossible if we introduced something incorrect.

@falko
Copy link
Member Author

falko commented May 13, 2024

Then a combination of linking to stable branches for maintained versions and to the last release tag for older unmaintained versions would work.

@christinaausley
Copy link
Contributor

#3795 (comment)

@akeller Unless you have immediate thoughts, let's discuss this (as in both PRs) and the solution in our 1:1 this week? Would be worth a style guide addition.

@christinaausley
Copy link
Contributor

I'll make a note to myself to adjust the latest link per each release 👍

@christinaausley christinaausley merged commit 65982b9 into main May 20, 2024
6 checks passed
@christinaausley christinaausley deleted the falko-patch-3 branch May 20, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed component:zeebe Issues related with Zeebe project
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants