-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vale): add rule for upper lower case titles #3576
Conversation
We are not following vale supported AP or Chicago styles
3d10270
to
bc603da
Compare
I like the idea! Some thoughts I have:
Just an FYI, from our perspective (DX team), we're unlikely to think about this PR much until after the upcoming minor release. |
Makes sense concerning the priority of the release! Agree, not sure what the long runtime is about since it's already just scoped to headings. If it's deemed useful, I would have another look over the regex and see what can be optimized. |
Thanks for proposing this @Langleu! A few things:
All in all, I don't mind fixing these headers as I review them. If this will create any noise in the PRs with errors or messages, I'd rather hold off, but if it will remain pretty quiet and I can add proper nouns to the list as I go, it might work. Makes me think I should start building out a custom "clippy" extension in my free time 😉 |
Hey 👋, I like the Clippy idea 😁. Maybe, that actually is an option to have it only for you for now as a tool to quickly check that kind of stuff and build a list along and introduce it globally at a later stage. |
This actually isn't a bad idea if I want to build it out before we use it more broadly. Could see how often it flags me as well to help determine the use we might get out of it! |
@christinaausley , I'll close the PR for now. |
Description
Just a proposal, we don't have to follow through with it, something I noticed that could be helpful to automate.
We are not following vale supported AP or Chicago styles for titles but rather
uppercase
followed bylowercase
.The following introduces a simple regex rule to filter out unsupported titles.
There are of course, a lot of proper nouns, I excluded some but stopped to hear whether this idea has any value for DevEx before putting work into it.
Additionally, there are maybe cases that we don't want to exclude that could simply be wrapped in the following to not trigger.
Let me know what you think.
When should this change go live?
hold
label or convert to draft PR)?PR Checklist
/versioned_docs
directory, or they are not for an already released version./docs
directory (aka/next/
), or they are not for future versions.