Skip to content

Commit

Permalink
improvement(ci): run build-docs CI check for external pull requests (#…
Browse files Browse the repository at this point in the history
…955)

* build: run build-docs for pull requests in addition to branch pushes

* docs(ci): add a helpful comment about why we have a condition in our build-docs job
  • Loading branch information
pepopowitz committed Jun 8, 2022
1 parent eadb23b commit dd304f9
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/build-docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,15 @@ on:
- "!main"
tags-ignore:
- "*"
pull_request:

jobs:
build-docs:
# For internal PRs, this will run on `push` events;
# for external/forked PRs, it will run on `pull_request` events.
# Ideally we'd have checked this condition when defining the triggers,
# but that's not supported by GitHub actions.
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down

0 comments on commit dd304f9

Please sign in to comment.