Use pyramid SecurityPolicy #9955
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
reviewed
Aug 10, 2022
| from macaroonbakery.bakery._identity import Identity | ||
|
|
||
|
|
||
| class SecurityPolicy(ISecurityPolicy): |
There was a problem hiding this comment.
Is it normal that self is missing in the ISecurityPolicy?
https://github.com/Pylons/pyramid/blob/1e439035e41da3767acbcae79689fb05dfdeb317/src/pyramid/interfaces.py#L502
There was a problem hiding this comment.
Same for other interfaces, but pretty sure we do not really need inheritance, just a class and methods with such prototype.
Inheritance can help for typing.
I do not know details about zope.Interface.
This is a draft for discussion, we will discuss, write tests and code.
But interesting catch anyway.
arnaud-morvan
commented
Aug 11, 2022
|
|
||
| from c2cgeoportal_geoportal.resources import defaultgroupsfinder | ||
| from jinja2.runtime import identity | ||
| from macaroonbakery.bakery._identity import Identity |
There was a problem hiding this comment.
IDE imports, remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.