Updated the Touch Height for the ios device. #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review my changes and accept my PR |
Update Slider.tsx
Update Slider.tsx
| @@ -285,7 +285,7 @@ SliderWithRef.defaultProps = { | |||
| }; | |||
|
|
|||
| let styles = StyleSheet.create( | |||
| Platform.OS === 'ios' ? {slider: {height: 40}} : {slider: {}}, | |||
| Platform.OS === 'ios' ? {slider: {}} : {slider: {}}, | |||
There was a problem hiding this comment.
With removing the height: 40 style, this line does actually nothing, and could even be simplified into:
Suggested change
| Platform.OS === 'ios' ? {slider: {}} : {slider: {}}, | |
| {slider: {}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan:
I needed to customize the height of the touch area for the ios so i have made changes to the file.