Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCED CUSTOMIZATION #173

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

ShaMan123
Copy link

@ShaMan123 ShaMan123 commented Apr 12, 2020

Continuing #164

This approach is much simpler than #164 .
It consists upon a ViewGroup laying out it's children above/below the slider. It's great. No caveats or performance hits.

Structure

Rendering a slider component now renders a view with 5 children:

  1. backgroundTrack
  2. maximumTrack
  3. minimumTrack
  4. slider
  5. thumb

The custom views are translated and scaled to appear exactly in position. This is done to avoid performance degradation, and so it does. Besides that I've taken pieces of valid code from the previous PR that fixes stuff.

Ready for reviewing!

This approach is much more agnostic, so writing the iOS implementation can be pretty much the same.

@ShaMan123 ShaMan123 changed the title View group android ENHANCED CUSTOMIZATION Apr 12, 2020
@BartoszKlonowski
Copy link
Member

Hello @ShaMan123!
Thank you for taking the time to implement such a huge change and sorry for that much delayed response...

I briefly went through the implementation and I would like to "resurrect" this topic.
Are you planning to, or would you like, to implement the missing iOS support?
I can spend some time this weekend (29.04 - 01.05) to rebase this and resolve all the conflicts.

Just in case: Feel no pressure, I already appreciate the work. Let me just know please what are your thoughts.

@ShaMan123
Copy link
Author

@BartoszKlonowski I no longer work on RN projects. Anyways I don't have a mac. So my answer is NO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants