-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENHANCED CUSTOMIZATION #173
base: main
Are you sure you want to change the base?
Conversation
fix clipping rect size
hide thumb while transitioning
Hello @ShaMan123! I briefly went through the implementation and I would like to "resurrect" this topic. Just in case: Feel no pressure, I already appreciate the work. Let me just know please what are your thoughts. |
@BartoszKlonowski I no longer work on RN projects. Anyways I don't have a mac. So my answer is NO. |
Continuing #164
This approach is much simpler than #164 .
It consists upon a
ViewGroup
laying out it's children above/below the slider. It's great. No caveats or performance hits.Structure
Rendering a slider component now renders a view with 5 children:
The custom views are translated and scaled to appear exactly in position. This is done to avoid performance degradation, and so it does. Besides that I've taken pieces of valid code from the previous PR that fixes stuff.
Ready for reviewing!
This approach is much more agnostic, so writing the iOS implementation can be pretty much the same.