Android: Apply slider padding from css #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Boss, will you merge, reject or request to update this feature? :) |
|
Since its java only, we will wait for iOS impl |
|
Please fix for ios also |
pft-developers
added a commit
to pft-developers/react-native-slider
that referenced
this pull request
Feb 22, 2021
| return (int) (dp * Resources.getSystem().getDisplayMetrics().density); | ||
| } | ||
|
|
||
| public static int pxToDp(int px) { |
There was a problem hiding this comment.
Why not just using PixelUtil, instead of implementing both conversions on your own?
|
@BlackJohnny & @wojteg1337 I believe that this could solve the #258, how do you think? |
|
Any news on this? |
|
It would be nice if we could fix the padding issue #258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR applies the padding information from the CSS style associated to the Slider component.
This can be useful when you need to add some overlay on the slider.
NOTE: I did not add the support for IOS. Maybe someone could help with this.
Test Plan:
or