-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TextInput loses focus inside Banner on iOS only #4179
base: main
Are you sure you want to change the base?
Conversation
fix: TextInput loses focus inside Banner on iOS only callstack#4178
Hey @abdulbasithqb, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
fix: removed duplicated style content
It may break a layout for users who pass a component as a child into the Banner
component
any suggestion to resolve this issue ? |
The problem with broken layout if we pass There are other potential cases where changes from this pull request might cause error for the users that already using Banner component:
<Banner visible={visible}>
first child
<Text>second child</Text>
</Banner>
<Banner visible={visible}>
<>some text</>
</Banner> Potential solutions that come to mind are either to check each child and wrap the strings in Text, or to treat this as a breaking change, but then it would not be a fix, but a major change |
Motivation
TextInput loses focus every type a character is entered and keyboard is dismissed. This happens only on iOS real device.
On android real device it works as expected.
Related issue
issue #4178
Result