Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #312 - no initial page load on Android #322

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

Lukas-Heiligenbrunner
Copy link
Contributor

Summary

fix #312 with workaround solution from @KusStar (see #312 (comment))

Checklist

  • I have tested this on a device and a simulator

src/PagerView.tsx Outdated Show resolved Hide resolved
@troZee troZee merged commit fe0de05 into callstack:master Apr 8, 2021
@danilobuerger
Copy link
Contributor

@Lukas-Heiligenbrunner @troZee this doesn't really fix the issue. Now you can first see the first page before it skips to the initialPage.

@sajorahasan
Copy link

Yes, I'm facing the same issue, I can see 0 index first before jumping to initialPage index.

@troZee
Copy link
Member

troZee commented Jun 7, 2021

@danilobuerger @sajorahasan could you try this PR ?

#368

@rashidul0405
Copy link

@Lukas-Heiligenbrunner @troZee this doesn't really fix the issue. Now you can first see the first page before it skips to the initialPage.

Same

@rashidul0405
Copy link

@troZee I just tested #368 and looks like the issue is fixed for android.

Step: yarn remove react-native-pager-view && yarn add callstack/react-native-pager-view#368/head && ENVFILE=.env.development npx react-native run-android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

initialPage does not work on Android with Hermes
5 participants