Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abiFilters to the native template #546

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

j-piasecki
Copy link
Contributor

Summary

In the native template abiFilters is missing from externalNativeBuild block. This means that the library would be built for every available ABI when building the application, even if the application itself is being built for a specific one. This is not that problematic (besides taking more time) when using React Native aar, but when building RN from source the core .so files will be built for that specific ABI. In case the library depends on a .so file, it would fail at the linking stage due to missing .so for the remaining ABIs.

Test plan

See

@atlj
Copy link
Collaborator

atlj commented Apr 26, 2024

Looks like this is failing some of the Android workflows. Can you take a look at them?

@tomekzaw
Copy link

tomekzaw commented May 8, 2024

@atlj Looks like all CIs failed because of Java heap space, can you please re-run failed jobs?

@satya164
Copy link
Member

@tomekzaw seems it's failing for all of the Android builds so it doesn't seem like flaky tests but an issue with the change.

…ndroid/build.gradle

Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
@satya164 satya164 merged commit c7dfe9e into callstack:main May 16, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants