Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: podspec file indentation #530

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: podspec file indentation #530

merged 1 commit into from
May 16, 2024

Conversation

olessavluk
Copy link
Contributor

Summary

After #358 identation become shifted which makes code hard to read and could lead to bugs. For example I was placing package dependencies inside if/else block, right after s.dependency "React-Core"

see

before after
image image

Test plan

Purely aesthetic changes, so nothing to break

@olessavluk
Copy link
Contributor Author

cc @ykhateeb

Copy link
Contributor

@ykhateeb ykhateeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @olessavluk, looks much better

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@satya164 satya164 merged commit 148fda0 into callstack:main May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants