feat: disable no-unused-prop-types rule #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sifted through the numerous false positive issues, and added a reduction of one of our cases that seemed to match:
jsx-eslint/eslint-plugin-react#1764
Summary
We ran into a few false positives with this rule, and it turns out there are over a dozen issues filed in eslint-plugin-react and a few unmerged PRs. Disabling it for now.
Test plan
I can add an example to the JS files that would fire if the rule is enabled and the false positive isn't fix yet. Let me know if that's necessary to merge and I'll add it.
Will no longer fire on this code (a reduction of a production case):