chore: add recommended rules from typescript eslint #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add recommended rules from Typescript Eslint.
Summary
Adds new rules to improve quality of code of the projects that use this config.
https://typescript-eslint.io/docs/linting/
There are also additional rules that use Typescript typechecking to verify code in a way that is not possible only with Eslint, but at the moment I'm not sure how to configure it in an external config.
At the moment only way to configure it seems to be for the user to setup an override in their configuration and add it manually themselves.
https://typescript-eslint.io/docs/linting/type-linting
On the other hand using TS for Eslint rule checking has a performance penalty that not everyone might want to pay, even though it is encouraged as type-aware linting has "additional powers" that are not possible without it.
https://typescript-eslint.io/docs/linting/type-linting#how-is-performance
Test plan
Verify that linting works fine and new rules are enforced.