chore: upgrade to react-scripts 5.0.1 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable is also used in dev.
* Update getProcessForPort.js * Update getProcessForPort.js Co-authored-by: Zhou Peng <zpbrent@gmail.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Including `%s/’/'/g` to avoid https://www.fileformat.info/info/unicode/char/2019/index.htm
This just fixes a shell snippet in the readme file for this plugin
Replace the Github home link with a link to the repo's main page or a link to the source (https://github.com/CodeByZach/pace/blob/master/pace.js)
Bump immer minor version to fix `Prototype Pollution` Security issue.
Co-authored-by: Brody McKee <mrmckeb@gmail.com>
…les libraries that contain sourcemaps (facebook#8227)
Co-authored-by: Brody McKee <mrmckeb@gmail.com>
HumbertoL
changed the title
HumbertoL
force-pushed
the
upgrade-cra5-with-multi-bundle
branch
2 times, most recently
from
e3e9061
to
b0946fb
Compare
HumbertoL
force-pushed
the
upgrade-cra5-with-multi-bundle
branch
3 times, most recently
from
7cc3a23
to
c4ec476
Compare
HumbertoL
force-pushed
the
upgrade-cra5-with-multi-bundle
branch
from
c4ec476
to
e57e07e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this PR is to upgrade react-scripts to update react-scripts to 5.0.1 while maintaining most of our customizations.
It's easiest to see the changes in this PR by comparing it to the upstream CRA: https://github.com/facebook/create-react-app/compare/main...callemall:upgrade-cra5-with-multi-bundle?expand=1
You can test this PR with r2d2 pr:
Note that we could not keep using the previous method of analyzing bundle sizes due to the fact that the webpack stats file was over 500mb. The plugin that we were using does not support reading files over 500mb with the CLI. The authors of this plugin are aware of the issue and do not plan to fix it: webpack-contrib/webpack-bundle-analyzer#492
As a workaround, I configured the plugin to instead generate a .html file that does not require the CLI to access.
Seen here is the error when the stats file is too large:
As for the unused code plugin, the authors have no intention to support Webpack 5. tomchentw/unused-files-webpack-plugin#39
We can consider replacing this library with
webpack-deadcode-pluginor another similar library in a future PR.All other features work with this PR, including the generation of separate bundles.