Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Safari broken rules #86

Merged
merged 17 commits into from Oct 1, 2021
Merged

Conversation

Lodin
Copy link
Collaborator

@Lodin Lodin commented Sep 6, 2021

Adds a detection and correction for Safari broken rules mentioned in #84.

@Lodin
Copy link
Collaborator Author

Lodin commented Sep 6, 2021

@calebdwilliams, could you please test this solution? Since I'm a Windows user, testing on Mac is pretty inconvenient for me. I'm concerned about if it correctly detects Safari browser and how many cases are supported correctly.

@Lodin Lodin marked this pull request as ready for review September 7, 2021 06:31
@Lodin Lodin marked this pull request as draft September 10, 2021 06:01
@Lodin
Copy link
Collaborator Author

Lodin commented Sep 10, 2021

Hmm, maybe I have an idea of a better solution...

@calebdwilliams
Copy link
Owner

@Lodin keep me posted

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@ded7a2e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage        ?   92.89%           
=======================================
  Files           ?        6           
  Lines           ?      211           
  Branches        ?       36           
=======================================
  Hits            ?      196           
  Misses          ?        4           
  Partials        ?       11           
Flag Coverage Δ
unittests 92.89% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ded7a2e...3625ec2. Read the comment docs.

@Lodin Lodin marked this pull request as ready for review September 24, 2021 12:57
@Lodin
Copy link
Collaborator Author

Lodin commented Sep 24, 2021

@calebdwilliams, I believe I finished the fix. Please test it with the Safari a bit more, because it might be that I haven't considered all the possible cases here.

@Lodin
Copy link
Collaborator Author

Lodin commented Sep 27, 2021

@calebdwilliams, do not mind my changes after the previous comment. That's mostly cosmetic optimizations. Please review and merge whenever you want.

Copy link
Owner

@calebdwilliams calebdwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code here looks good to me, but the first time I tested this, Safari crashed. I don't think the two are related, but I'm going to try to stress test this a bit first before merging/releasing.

@calebdwilliams calebdwilliams merged commit 7e7f05b into calebdwilliams:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants