New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Safari broken rules #86
Conversation
@calebdwilliams, could you please test this solution? Since I'm a Windows user, testing on Mac is pretty inconvenient for me. I'm concerned about if it correctly detects Safari browser and how many cases are supported correctly. |
Hmm, maybe I have an idea of a better solution... |
@Lodin keep me posted |
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
=======================================
Coverage ? 92.89%
=======================================
Files ? 6
Lines ? 211
Branches ? 36
=======================================
Hits ? 196
Misses ? 4
Partials ? 11
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@calebdwilliams, I believe I finished the fix. Please test it with the Safari a bit more, because it might be that I haven't considered all the possible cases here. |
@calebdwilliams, do not mind my changes after the previous comment. That's mostly cosmetic optimizations. Please review and merge whenever you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code here looks good to me, but the first time I tested this, Safari crashed. I don't think the two are related, but I'm going to try to stress test this a bit first before merging/releasing.
Adds a detection and correction for Safari broken rules mentioned in #84.