Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storybook builds #10941

Closed
wants to merge 4 commits into from
Closed

fix: storybook builds #10941

wants to merge 4 commits into from

Conversation

zomars
Copy link
Member

@zomars zomars commented Aug 25, 2023

What does this PR do?

  • Upgrades babel plugin to support TS satisfies
image

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ❌ Failed (Inspect) Aug 26, 2023 8:21am
cal-demo ❌ Failed (Inspect) Aug 26, 2023 8:21am
dev ❌ Failed (Inspect) Aug 26, 2023 8:21am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2023 8:21am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2023 8:21am
qa ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2023 8:21am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

Thank you for following the naming conventions! 🙏

@@ -15,7 +15,6 @@ const nextConfig = {
},
transpilePackages: [
"@calcom/app-store",
"@calcom/dayjs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-08-25 at 6 41 05 PM

is this failing the type-check?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly, seems also failing when removing type checks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zomars type checks are still failing for some reason

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
jest-diff 29.5.0...29.6.1 None +2/-2 527 kB simenb

@hariombalhara
Copy link
Member

I raised a different PR that upgrades storybook and it fixes the issue #10983

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2023

CLA assistant check
All committers have signed the CLA.

@Udit-takkar
Copy link
Contributor

This PR fixes the issue #11037 @zomars

@PeerRich PeerRich added Medium priority Created by Linear-GitHub Sync ci area: CI, DX, pipeline, github actions labels Sep 7, 2023
@PeerRich PeerRich closed this Sep 7, 2023
auto-merge was automatically disabled September 7, 2023 17:29

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci area: CI, DX, pipeline, github actions core area: core, team members only Medium priority Created by Linear-GitHub Sync
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

6 participants