Vendoring libnetwork #17
Conversation
Commit id: 3daf67270570c1e07e3e3184d46a10f0c5d66f87 Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
|
I don't really know how to review, it's unclear which change applies to which issue :-/ |
| "net" | ||
| "os/exec" | ||
| "strings" | ||
| "sync" | ||
|
|
||
| "github.com/Sirupsen/logrus" | ||
| bri "github.com/docker/libcontainer/netlink" |
There was a problem hiding this comment.
Does it mean that libnetwork vendors libcontainer now? Is that a temporary thing to support RHEL6 by reusing libcontainer magical fallback logic on ancestral kernels?
There was a problem hiding this comment.
@icecrime @LK4D4 This is a temporary thing to support RHEL6 and we are only pulling in libcontainer/netlink not the whole thing.
As a side note, this is not in master(may not ever be) because if we are saying that we are going to drop support for RHEL6 in 1.8 I would rather not have this fallback logic in the master
|
@mrjana There are a few test files, should we remove them? |
|
I guess it's fine, the files were there already |
|
Cherry picked into b03b8a2. Thank you! |
Commit id: 3daf67270570c1e07e3e3184d46a10f0c5d66f87
Fixes moby#14184, moby#14037, moby#14024, moby#14246
Signed-off-by: Jana Radhakrishnan mrjana@docker.com