Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update docs on tagging a release #2104

Merged
merged 2 commits into from
May 28, 2024
Merged

Chore: update docs on tagging a release #2104

merged 2 commits into from
May 28, 2024

Conversation

angela-tran
Copy link
Member

We have been using annotated tags, so this updates our docs to reflect that.

we have been using annotated tags, so this updates our docs to reflect that.
@angela-tran angela-tran self-assigned this May 15, 2024
@github-actions github-actions bot added documentation [auto] Improvements or additions to documentation infrastructure Terraform, Azure, etc. labels May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/core
  models.py
  benefits/enrollment
  analytics.py
  views.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link

Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @angela-tran ! I added a few more details about the annotation message as a suggested change. The suggested change preview looks a little weird but hopefully the raw text is clear.

@@ -87,7 +87,7 @@ git checkout prod

git reset --hard origin/prod

git tag YYYY.0M.R
git tag -a YYYY.0M.R

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Git will open your default text editor and prompt you for the tag annotation. For the tag annotation, use the title of the release-tagged Issue that kicked off the release. Finally, after closing the text editor:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to add more details on this! I see what you mean with the raw text. I'll make that change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 64c404b

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@angela-tran angela-tran marked this pull request as ready for review May 23, 2024 17:11
@angela-tran angela-tran requested a review from a team as a code owner May 23, 2024 17:11
@angela-tran angela-tran requested a review from lalver1 May 23, 2024 17:11
@angela-tran angela-tran merged commit b5c20c2 into dev May 28, 2024
10 checks passed
@angela-tran angela-tran deleted the docs/annotated-tag branch May 28, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation [auto] Improvements or additions to documentation infrastructure Terraform, Azure, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants