-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: update docs on tagging a release #2104
Conversation
we have been using annotated tags, so this updates our docs to reflect that.
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
Preview url: https://benefits-2104--cal-itp-previews.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR @angela-tran ! I added a few more details about the annotation message as a suggested change. The suggested change preview looks a little weird but hopefully the raw text is clear.
@@ -87,7 +87,7 @@ git checkout prod | |||
|
|||
git reset --hard origin/prod | |||
|
|||
git tag YYYY.0M.R | |||
git tag -a YYYY.0M.R | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git will open your default text editor and prompt you for the tag annotation. For the tag annotation, use the title of the release
-tagged Issue that kicked off the release. Finally, after closing the text editor:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to add more details on this! I see what you mean with the raw text. I'll make that change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 64c404b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
We have been using annotated tags, so this updates our docs to reflect that.