Restored migration template method return types #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance we can get a 🏷️ tag for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously added this in #1819 but it was (inadvertently?) reverted in #1995, which claimed to be adding type hints, but actually removed them, at least in migration templates, as we can see in this commit. That commit purports to be fixing tests, but as we can see from this PR, no tests (at least at the present time) are broken by adding such types.
Since Phinx currently requires PHP 7.2, and void functions were added in PHP 7.1, there doesn't seem to be a compelling reason to not to add these types.