Try stricter API for Command args existence. #17654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Apr 6, 2024
|
Yeah probably |
dereuromark
force-pushed
the
5.x-stricter-args-options
branch
2 times, most recently
from
928e261
to
7a3de21
Compare
dereuromark
force-pushed
the
5.x-stricter-args-options
branch
from
e1bafa9
to
d0ab55c
Compare
|
@markstory leaving this one for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17647
We can only control the named and defined arguments.
Everything else is not clearly known to the class, and we probably cannot easily change that at this point.