Add logging to error rendering failures #17615
Conversation
When error rendering fails it can be tedious to diagnose what the problem is. Having some logging when rendering fails could help triage the problem and get to a solution quicker. Refs #17603
markstory
force-pushed
the
error-renderer-log
branch
from
dfd1d3e
to
bcacc66
Compare
| Log::warning( | ||
| "Failed to construct or call startup() on the resolved controller class of `$class`. " . | ||
| "Using Fallback Controller instead. Error {$e->getMessage()}", | ||
| 'cake.error' |
There was a problem hiding this comment.
New logging has a scope so folks can silence this scope if required. If this is happening frequently in an application I think the application is broken 🤷
There was a problem hiding this comment.
Why do we need cake.error if we have log levels? Why not just cake?
There was a problem hiding this comment.
Why do we need cake.error if we have log levels? Why not just cake?
I could see a scenario where folks have existing applications that they want to get warnings from but not this warning. Having routes based on module/package names felt like a natural pairing with namespaces. I use a similar approach in python applications and it gives you a lot of flexibility in how you can configure logging from your application.
When error rendering fails it can be tedious to diagnose what the problem is. Having some logging when rendering fails could help triage the problem and get to a solution quicker.
Refs #17603