Make Route normalize HTTP method conditions

[markstory]

By normalizing the http method name to the correct case resource routes are a bit more ergonomic as case mistakes don't cause routes to fail matching.

Fixes #14902

[othercorey]

Looks ok

[ADmad]

Don't we have constants for request method types?

[othercorey]

Are you suggesting we validate the names instead of making them work?

[ADmad]

Normally I would say "yes", but in this particular case I guess we don't need to be too pedantic about the casing user uses. Though I was surprised to see strings being used for method types in our codebase too instead of constants.

[othercorey]

Well. it is bad that users can pass invalid methods. Forget casing, which is east to fix. What if they misspell "post"?

[ADmad]

That's why we should provide constants and let those using strings suffer their typos 😛.

[markstory]

We could add constants, and validate that the methods are within the accepted range, but that is a different change that would need to go into 4.next. I would likely put the constants on RouteBuilder so that users wouldn't need to do additional imports if they already are using typehinting.

[dereuromark]

Those constants already exist for user land code to be used by the way in Cake\Http\Client\Message:

/**
 * HTTP GET method
 *
 * @var string
 */
public const METHOD_GET = 'GET';

/**
 * HTTP POST method
 *
 * @var string
 */
public const METHOD_POST = 'POST';

etc

[markstory]

Those constants already exist for user land code to be used by the way in Cake\Http\Client\Message:

Its a bit odd to need to import the HTTP client when defining routes though.

[dereuromark]

Sure, just saying: if u wanted you could already use constants.

[ADmad]

I added a new normalizeAndValidateMethods() method to get rid of the multiple strtoupper calls scattered across methods and also validate methods names in all arguments.

[ADmad]

The test failures are because signature of RedirectRoute::parse(string $url, string $method = '') doesn't match Route::parse(string $url, string $method).

Is there any reason why RedirectRoute has $method as empty string by default? If not we can just remove the default value and update tests to pass a value.

[markstory]

Is there any reason why RedirectRoute has $method as empty string by default? If not we can just remove the default value and update tests to pass a value.

Probably an accident/omission.

[ADmad]

Apparently all child methods of Route::parse() which override parse() have a default value for $method and so does RouteCollection::parse(). So removing the default argument would cause lot of test failures.

So I am going to keep the signatures as they are.