Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpstan config. #14692

Merged
merged 3 commits into from
Jun 14, 2020
Merged

Update phpstan config. #14692

merged 3 commits into from
Jun 14, 2020

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Jun 9, 2020

No description provided.

@ADmad ADmad added this to the 4.0.9 milestone Jun 9, 2020
@ADmad
Copy link
Member Author

ADmad commented Jun 9, 2020

Awaiting following issues to be fixed:

phpstan/phpstan#3422
phpstan/phpstan#3415

@ADmad ADmad marked this pull request as ready for review June 14, 2020 17:10
@othercorey
Copy link
Member

Looks ok to me.

@dereuromark dereuromark merged commit 319824a into master Jun 14, 2020
@dereuromark dereuromark deleted the phpstan branch June 14, 2020 19:06
@dereuromark
Copy link
Member

Looking at the shrinking https://github.com/cakephp/cakephp/blob/master/phpstan-baseline.neon file it seems we have now by far the cleanest codebase (in terms of static analysis) - regarding all larger repos out there in terms of popularity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants