Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Split combined getter/setter EntityInterface::isNew(). #13497

Merged
merged 3 commits into from
Aug 10, 2019
Merged

Backport: Split combined getter/setter EntityInterface::isNew(). #13497

merged 3 commits into from
Aug 10, 2019

Conversation

robertpustulka
Copy link
Member

Refs #13455

@robertpustulka
Split combined getter/setter EntityInterface::isNew().
80c6e9a 
isNew() now only acts as getter and new method setNew() has been added as setter.
@robertpustulka robertpustulka added this to the 3.9.0 milestone Aug 9, 2019
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #13497 into 3.next will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             3.next   #13497      +/-   ##
============================================
+ Coverage     90.95%   90.95%   +<.01%     
- Complexity    14026    14027       +1     
============================================
  Files           523      523              
  Lines         36195    36197       +2     
============================================
+ Hits          32921    32923       +2     
  Misses         3274     3274
Impacted Files Coverage Δ Complexity Δ
src/ORM/Entity.php 100% <100%> (ø) 8 <0> (ø) ⬇️
src/Datasource/EntityTrait.php 88.22% <100%> (+0.05%) 176 <5> (+1) ⬆️
src/ORM/Table.php 94.53% <100%> (ø) 294 <0> (ø) ⬇️
src/ORM/Association/BelongsToMany.php 98.79% <100%> (ø) 167 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce940d5...b7a678b. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 9, 2019 •
edited

Codecov Report

Merging #13497 into 3.next will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             3.next   #13497      +/-   ##
============================================
+ Coverage     90.95%   90.95%   +<.01%     
- Complexity    14026    14043      +17     
============================================
  Files           523      523              
  Lines         36195    36228      +33     
============================================
+ Hits          32921    32952      +31     
- Misses         3274     3276       +2
Impacted Files Coverage Δ Complexity Δ
src/ORM/Entity.php 100% <100%> (ø) 8 <0> (ø) ⬇️
src/Datasource/EntityTrait.php 88.22% <100%> (+0.05%) 176 <5> (+1) ⬆️
src/ORM/Table.php 94.5% <100%> (-0.04%) 310 <0> (+16)
src/ORM/Association/BelongsToMany.php 98.79% <100%> (ø) 167 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce940d5...b7a678b. Read the comment docs.

@markstory markstory merged commit 5857838 into cakephp:3.next Aug 10, 2019
@robertpustulka robertpustulka deleted the backport-set-new branch September 2, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADmad ADmad ADmad approved these changes

Assignees
No one assigned
Labels
datasource
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertpustulka @ADmad @markstory