Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docblocks. #13456

Merged
merged 3 commits into from Aug 2, 2019
Merged

Update docblocks. #13456

merged 3 commits into from Aug 2, 2019

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Aug 2, 2019

No description provided.

@ADmad ADmad added this to the 4.0.0 milestone Aug 2, 2019
@ADmad
Copy link
Member Author

ADmad commented Aug 2, 2019 •
edited

These test failure are due to BC breakage in phpunit 8.3.

sebastianbergmann/phpunit#3774

@ADmad
Update use of deprecated MockBuilder::setMethods().
2b47b1f 
As a result TestCase::getMockModel() no longer accepts null or non existent methods
for it's $methods argument.
@ADmad ADmad mentioned this pull request Aug 2, 2019
Merged
@ADmad
Copy link
Member Author

ADmad commented Aug 2, 2019 •
edited

TestCase::getMockForModel() had to be updated to deal with deprecations in phpunit 8.3. Please check commit for details.

@ADmad
Copy link
Member Author

ADmad commented Aug 2, 2019 •
edited

Code coverage runs are now way faster with use of pcov instead of phpdbg / xebug.

@markstory markstory merged commit 677d1c4 into 4.x Aug 2, 2019
@markstory markstory deleted the 4.x-decimaltype-docblock branch August 2, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereuromark dereuromark dereuromark approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ADmad @dereuromark @mirko-pagliai @markstory @ravage84