Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow #383

Merged
merged 5 commits into from Apr 9, 2023
Merged

Update CI workflow #383

merged 5 commits into from Apr 9, 2023

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Apr 9, 2023

No description provided.

@ADmad ADmad added this to the 5.x milestone Apr 9, 2023
@ADmad ADmad force-pushed the 5.x-ci-workflow branch 3 times, most recently from c9e145a to e76a2ab Compare April 9, 2023 09:16
@ADmad ADmad marked this pull request as ready for review April 9, 2023 09:33
@ADmad
Copy link
Member Author

ADmad commented Apr 9, 2023

Looking through squizlabs/PHP_CodeSniffer's testsuite GA workflow I figured out how to run our test suite on PHP 8.1+ without updating phpunit.

@dereuromark dereuromark merged commit 3897d72 into 5.x Apr 9, 2023
4 checks passed
@dereuromark dereuromark deleted the 5.x-ci-workflow branch April 9, 2023 10:11
@ADmad
Copy link
Member Author

ADmad commented Apr 9, 2023

@dereuromark Can you please add the phpstan checks you added in #369 on top of this please? Then that PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants