[2.x] Support Non-Table Models #985
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May be But this could be implemented separately, I guess. |
|
One issue with the test suite seem unrelated. Fixed in #986 PR needs to be updated, once merged. |
|
I did not update the code criticized by PHPStan:
https://github.com/cakephp/bake/actions/runs/8847219659/job/24294625577?pr=985#step:7:13 |
dereuromark
approved these changes
Apr 26, 2024
|
We should probably finish and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative branch to #953
I couldn't push my changes to @asgraf's PR branch, thus added the requested test coverage changes by @markstory in a new branch on the origin repo.
If these changes do not satisfy, please feel free to amend and extend my additions.
Ping back @dereuromark