Allow for singular table names when baking fixtures #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $data = $schemaCollection->describe($useTable); | ||
| try { | ||
| $data = $schemaCollection->describe($useTable); | ||
| } catch (Exception $e) { |
There was a problem hiding this comment.
You should catch the specific exception
There was a problem hiding this comment.
I am. Schema/Collection::describe() throws a Cake\Database\Exception, which is what I'm catching here.
|
I had the same issues with recommended i18n table. |
|
Is it possible to add a test for this? |
|
Test done :) |
|
Any reason you didn't use the |
|
Maybe he tried to generate fixtures with |
|
@markstory, I was running |
|
Ok, with |
markstory
added a commit
that referenced
this pull request
May 7, 2015
Allow for singular table names when baking fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered a use case where I am baking fixtures for all my tables. I have a few tables where the table name is singular. This PR adds in the ability to fallback to a singular table if the plural version does not exist.