Skip to content

Commit

Permalink
Fix broken image import in bundled build.
Browse files Browse the repository at this point in the history
The line I removed set resolveProxyImports to false for bundled builds and cause image and json files to be imported directly instead of through proxy imports.

This change fixes:

[BUG] sowpack bundle build generate import statement for images and json files FredKSchott#3109
FredKSchott#3109
  • Loading branch information
cain-wang committed Apr 21, 2021
1 parent 01e036a commit 69bce71
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions snowpack/src/build/process.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,6 @@ export async function createBuildState(commandOptions: CommandOptions): Promise<
const isSSR = !!config.buildOptions.ssr;
const isHMR = getIsHmrEnabled(config);

// Seems like maybe we shouldn't be doing this...
config.buildOptions.resolveProxyImports = !config.optimize?.bundle;
config.devOptions.hmrPort = isHMR ? config.devOptions.hmrPort : undefined;
config.devOptions.port = 0;

Expand Down

0 comments on commit 69bce71

Please sign in to comment.