New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Stream test bug fix #539
Conversation
a88ddc7
to
9f98be5
Compare
But all the tests shown already were using it within a context manager? 😕😕😕 It looks like what this is doing is really moving to a single |
@joerunde yeah the only difference was the session scoping of the fixture that was making it work. It doesn't work without that unfortunately :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I'm here for the test code simplification, the fixture for the client is really nice. Let us know if you find out any more details about why this thing hangs!
@joerunde Now I'm thinking making the fixture session-scoped is not the right thing to do. Adding another test that pings an actual running server and using that along with either a function scoped or a session scoped test fixture doesn't seem to work :( My gut feeling is that |
Signed-off-by: Prashant Gupta <prashantgupta24@gmail.com>
Signed-off-by: Prashant Gupta <prashantgupta24@gmail.com>
Signed-off-by: Prashant Gupta <prashantgupta24@gmail.com>
Signed-off-by: Prashant Gupta <prashantgupta24@gmail.com>
Signed-off-by: Prashant Gupta <prashantgupta24@gmail.com>
7b2333d
to
f2e9e33
Compare
What this PR does / why we need it:
This PR adds:
fastapi.testclient
fix #540
Special notes for your reviewer:
If applicable: