Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock now takes a context and should honor cancellation #66

Merged
merged 2 commits into from May 27, 2020
Merged

Lock now takes a context and should honor cancellation #66

merged 2 commits into from May 27, 2020

Commits on Apr 14, 2020

  1. Lock now takes a context and should honor cancellation 

    This allows callers to give up if they can't obtain a lock in a certain
timeframe and for resources to be cleaned up, avoiding potential
resource leaks.

Breaking change for any Storage implementations, sorry about that. (It's
why we're not 1.0 yet.) I'll reach out to known implementations; it's a
simple change.
    @mholt
    mholt committed Apr 14, 2020
    Copy the full SHA
    092820a View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. Rename obtainLock to acquireLock to be less ambiguous 

    In our package, "obtain" has a more common meaning related to certs
    @mholt
    mholt committed May 27, 2020
    Copy the full SHA
    a227469 View commit details
    Browse the repository at this point in the history