Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Lock now takes a context and should honor cancellation (#66)
* Lock now takes a context and should honor cancellation This allows callers to give up if they can't obtain a lock in a certain timeframe and for resources to be cleaned up, avoiding potential resource leaks. Breaking change for any Storage implementations, sorry about that. (It's why we're not 1.0 yet.) I'll reach out to known implementations; it's a simple change. * Rename obtainLock to acquireLock to be less ambiguous In our package, "obtain" has a more common meaning related to certs
- Loading branch information
Showing
3 changed files
with
19 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters