Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pathEscape template function and use it in browse.html #6278

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DenebTM
Copy link

@DenebTM DenebTM commented Apr 27, 2024

See #6237

Unsure about including a function from the url module in c.tpl.Funcs, but I see little point in adding a wrapper for it.

(Also, perhaps more functions from the url module should be made available in templates.)

- add `pathEscape` to c.tpl.Funcs, using `url.PathEscape`
- use `pathEscape` in browse.html in place of `replace`
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my radio silence on this. Probably a good change.

Do we still need to pipe to html after doing path escape?

Anyway, LGTM otherwise. Will wait to merge though until I understand for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants