close quic connections when server closes #6202
Conversation
There was a problem hiding this comment.
LGTM. This is a good temporary solution I think. Thank you @WeidiDeng!!
|
This means that h3 requests get cancelled non-gracefully on reload, right? Doesn't that differ from how we typically handle reloads? Does that ignore the grace config in global options https://caddyserver.com/docs/caddyfile/options#grace-period ? |
|
Yeah, I think so. I believe it is a TODO, waiting for a graceful close method upstream in quic-go. I believe what this does -- correct me if I'm wrong @WeidiDeng -- is when a new HTTP request comes in on a server that was just closed, it will close the QUIC connection with the client. The socket remains open, however. @marten-seemann Does that sound about right? Once a graceful close is implemented we should be able to allow existing requests to finish during a grace period I think? |
|
Speaking of request interruption, I think my previous approach to interrupt a stream had the same problem (the quic connection is forcefully closed). I'll take a look at that and graceful shutdown when I have time. |
|
Thanks Weidi, that'd be great 👍 |
Fix 6195.