Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dheerajsingh0-#5858-Revise-redir-status-code-shortcuts #5868

Conversation

dheerajsingh0
Copy link

@dheerajsingh0 dheerajsingh0 commented Oct 7, 2023

PR Update for redir Directive in Caddyfile
Reference: Caddyserver's redir Directive

Changes Proposed:

Introduced new shortcuts for HTTP redirection codes:
temporary-strict maps to 307 Temporary Redirect.
permanent-strict maps to 308 Permanent Redirect.
Ensured existing redirection codes are retained:
temporary (or no code) maps to 302 Found.
permanent maps to 301 Moved Permanently.
Extended documentation to specify behavior of different HTTP methods during redirection and clarified client responsibilities for conformance.
Rationale:
Previously, only two shortcuts were available for redirections: temporary and permanent. While these cover the most common redirections, there are scenarios where a client needs to differentiate between a 302 Found and a 307 Temporary Redirect, or between a 301 Moved Permanently and a 308 Permanent Redirect.

The inclusion of the new shortcuts ensures that Caddy users have granular control over their redirection behaviors. Furthermore, enhanced documentation ensures clarity in client-server interactions during redirections, promoting conformance and predictability.

Feedback and further suggestions are welcome!

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2023

CLA assistant check
All committers have signed the CLA.

@dheerajsingh0
Copy link
Author

@francislavoie Please review my PR and Share your Feedback.

@mholt
Copy link
Member

mholt commented Apr 11, 2024

Think we still need to decide on a path forward in #5858.

@mholt
Copy link
Member

mholt commented Apr 24, 2024

Closing for now, due to inactivity on this PR and also the linked issue, plus a decision still needs to be made about what to do (if anything). And there's a merge conflict now anyway.

Thanks for making the PR, we can either reopen or consider a new one after more discussion has taken place and we're confident in a decision going forward.

@mholt mholt closed this Apr 24, 2024
@mholt mholt added the declined 🚫 Not a fit for this project label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined 🚫 Not a fit for this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants