adding h2c graceful shutdown #4920
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm looking forward to reviewing this. |
WeidiDeng
force-pushed
the
h2c-graceful
branch
from
0f9849a
to
df54c0c
Compare
|
Thank you for this change @WeidiDeng -- if it's OK with you, I'm going to bump this to after 2.6 (or at least after its initial beta) just so I can stay on a self-imposed schedule 🤪 I will review this though! |
# Conflicts: # modules/caddyhttp/app.go
| ) | ||
|
|
||
| // h2chandler is a Handler which counts possible h2c upgrade requests | ||
| type h2chandler struct { |
There was a problem hiding this comment.
Shouldn't this be uppercase, as a separate word?
Suggested change
| type h2chandler struct { | |
| type h2cHandler struct { |
|
Will take another look when it's updated and ready for another review (as discussed in Slack). 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 4907