Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Ensure we always check for latest version of Go #4703

Merged
merged 5 commits into from Apr 13, 2022
Merged

ci: Ensure we always check for latest version of Go #4703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f92054
ci: Ensure we always check for latest version of Go
francislavoie Apr 13, 2022
0af186e
Try to force 1.18.1, 1.17.9
francislavoie Apr 13, 2022
34d83af
Use includes for the actual go semver
francislavoie Apr 13, 2022
0e96e2e
Use `~` for semver here, apparently
francislavoie Apr 13, 2022
316aba1
Try to make tests still run on 1.18.0 for Mac, for now
francislavoie Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -21,10 +21,23 @@ jobs:
os: [ ubuntu-latest, macos-latest, windows-latest ]
go: [ '1.17', '1.18' ]

include:
# Set the minimum Go patch version for the given Go minor
# Usable via ${{ matrix.GO_SEMVER }}
- go: '1.17'
GO_SEMVER: '~1.17.9'

- go: '1.18'
GO_SEMVER: '~1.18.1'

# Go 1.18.1 isn't released yet for Mac as of Apr 13 2022
- go: '1.18'
os: 'macos-latest'
GO_SEMVER: '1.18.0'

# Set some variables per OS, usable via ${{ matrix.VAR }}
# CADDY_BIN_PATH: the path to the compiled Caddy binary, for artifact publishing
# SUCCESS: the typical value for $? per OS (Windows/pwsh returns 'True')
include:
- os: ubuntu-latest
CADDY_BIN_PATH: ./cmd/caddy/caddy
SUCCESS: 0
Expand All @@ -43,7 +56,8 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go }}
go-version: ${{ matrix.GO_SEMVER }}
check-latest: true

- name: Checkout code
uses: actions/checkout@v3
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/cross-build.yml
View file
Open in desktop
Expand Up @@ -17,13 +17,21 @@ jobs:
matrix:
goos: ['android', 'linux', 'solaris', 'illumos', 'dragonfly', 'freebsd', 'openbsd', 'plan9', 'windows', 'darwin', 'netbsd']
go: [ '1.18' ]

include:
# Set the minimum Go patch version for the given Go minor
# Usable via ${{ matrix.GO_SEMVER }}
- go: '1.18'
GO_SEMVER: '~1.18.1'

runs-on: ubuntu-latest
continue-on-error: true
steps:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go }}
go-version: ${{ matrix.GO_SEMVER }}
check-latest: true

- name: Print Go version and environment
id: vars
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Expand Up @@ -19,7 +19,8 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: 1.17
go-version: '~1.17.9'
check-latest: true

- name: golangci-lint
uses: golangci/golangci-lint-action@v3
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Expand Up @@ -12,13 +12,21 @@ jobs:
matrix:
os: [ ubuntu-latest ]
go: [ '1.18' ]

include:
# Set the minimum Go patch version for the given Go minor
# Usable via ${{ matrix.GO_SEMVER }}
- go: '1.17'
GO_SEMVER: '~1.18.1'
mholt marked this conversation as resolved.
Show resolved Hide resolved

runs-on: ${{ matrix.os }}

steps:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go }}
go-version: ${{ matrix.GO_SEMVER }}
check-latest: true

- name: Checkout code
uses: actions/checkout@v3
Expand Down