Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpcaddyfile: Add default_bind global option #4531

Merged
merged 1 commit into from Jan 18, 2022
Merged

Conversation

francislavoie
Copy link
Member

Address some feedback in #4508, /cc @phrazer

This is pretty self explanatory, simple addition.

@francislavoie francislavoie added feature ⚙️ New feature or request under review 🧐 Review is pending before merging labels Jan 18, 2022
@francislavoie francislavoie added this to the v2.5.0 milestone Jan 18, 2022
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for implementing this. :)

@mholt mholt merged commit 1b7ff5d into master Jan 18, 2022
@mholt mholt removed the under review 🧐 Review is pending before merging label Jan 18, 2022
@mholt mholt deleted the caddyfile-default-bind branch January 18, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants