Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverseproxy: Adjust defaults, document defaults #4436

Merged
merged 3 commits into from Nov 24, 2021
Merged

Commits on Nov 24, 2021

  1. reverseproxy: Adjust defaults, document defaults

    Related to some of the issues in #4245, a complaint about the proxy transport defaults not being properly documented in https://caddy.community/t/default-values-for-directives/14254/6.
    
    - Dug into the stdlib to find the actual defaults for some of the timeouts and buffer limits, documenting them in godoc so the JSON docs get them next release.
    
    - Moved the keep-alive and dial-timeout defaults from `reverseproxy.go` to `httptransport.go`. It doesn't make sense to set defaults in the proxy, because then any time the transport is configured with non-defaults, the keep-alive and dial-timeout defaults are lost!
    
    - Sped up the dial timeout from 10s to 3s, in practice it rarely makes sense to wait a whole 10s for dialing. A shorter timeout helps a lot with the load balancer retries, so using something lower helps with user experience.
    francislavoie committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    d6d1ef0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e24ad1f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0df1259 View commit details
    Browse the repository at this point in the history