reverseproxy: Move status replacement intercept to replace_status
#4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislavoie
force-pushed
the
caddyfile-replace-status
branch
3 times, most recently
from
fc4b1d9
to
5cfac4e
Compare
francislavoie
force-pushed
the
caddyfile-replace-status
branch
2 times, most recently
from
5012ddd
to
ca75021
Compare
francislavoie
force-pushed
the
caddyfile-replace-status
branch
from
ca75021
to
7ceb536
Compare
francislavoie
force-pushed
the
caddyfile-replace-status
branch
from
7ceb536
to
48e83f9
Compare
francislavoie
force-pushed
the
caddyfile-replace-status
branch
from
48e83f9
to
0995aac
Compare
mholt
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing some thinking in #4298 (comment) and I think the UX of
handle_responseis super awkward in that it was doing two different things in one subdirective.Semantically, it's expected that the
handlefamily of options imply that subroutes will be defined (as perhandleandhandle_pathdirectives).Separating the status code replacement usecase into its own Caddyfile subdirective (even if it doesn't match the JSON 1:1) is easier to understand.
This is a breaking change, so we could defer this to v2.5.0, but I don't think many people use this yet so the impact should be very low. I haven't seen anyone on the forums asking questions using this feature yet since we released it in v2.4.0.