Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: allow disabling OpenMetrics negotiation #3944

Merged
merged 2 commits into from Dec 30, 2020
Merged

metrics: allow disabling OpenMetrics negotiation #3944

merged 2 commits into from Dec 30, 2020

Conversation

hairyhenderson
Copy link
Collaborator

@hairyhenderson hairyhenderson commented Dec 30, 2020 •
edited

Fixes #3940 by allowing users to disable OpenMetrics negotiation. This shouldn't usually be necessary, but there's a couple of incompatible metric names in the upstream Go collector which break strict parsing. I'll also log a bug in prometheus/client_golang and link it here.

Documentation PR is here: caddyserver/website#123

Signed-off-by: Dave Henderson dhenderson@gmail.com

@hairyhenderson hairyhenderson mentioned this pull request Dec 30, 2020
Closed
@hairyhenderson
Copy link
Collaborator Author

Not sure why goreleaser-check is failing - @francislavoie @mohammed90 any ideas?

@hairyhenderson hairyhenderson mentioned this pull request Dec 30, 2020
Merged
@mohammed90
Copy link
Member

@hairyhenderson the failure is due to deprecation notices. See https://goreleaser.com/deprecations#nfpmsfiles and https://goreleaser.com/deprecations#nfpmsconfig_files

@francislavoie fixed it in:

8286f8d

@francislavoie
Copy link
Member

Sorry about that - I cherrypicked it into #3945 and I'll merge it asap, no use just leaving it in my unrelated PR.

@francislavoie
Copy link
Member

Okay merged, you could rebase to re-run CI if you like.

@mholt mholt added this to the v2.3.0 milestone Dec 30, 2020
@hairyhenderson
Copy link
Collaborator Author

Alright - rebased!

mholt
mholt previously approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dave!

Oof, the golang prometheus client is getting heavier and heavier :(

I don't love having such a deep dependency chain. Something we will have to come back and address later probably.

@hairyhenderson
Copy link
Collaborator Author

Oof, the golang prometheus client is getting heavier and heavier :(

I don't love having such a deep dependency chain. Something we will have to come back and address later probably.

There's a related conversation in the prometheus/common repo (where most of the new dependencies come from I think): prometheus/common#255 - my impression is many of those dependencies aren't really that relevant since they don't end up in the final binary.

@mholt
Copy link
Member

mholt commented Dec 30, 2020 •
edited

Thanks for linking that.

my impression is many of those dependencies aren't really that relevant since they don't end up in the final binary.

And that's good, but it still makes pulling repos really slow and tedious. And easier for things to break then, which makes development hard. Anyway, I commented in that issue.

mholt
mholt approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge momentarily and cut rc2 to test the updated CI pipeline

@mholt mholt merged commit ebc278e into caddyserver:master Dec 30, 2020
@hairyhenderson hairyhenderson deleted the make-openmetrics-optional-3940 branch December 30, 2020 19:03
@beorn7 beorn7 mentioned this pull request Jan 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislavoie francislavoie francislavoie left review comments

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

Metrics clashing name
4 participants
@hairyhenderson @mohammed90 @francislavoie @mholt