Skip to content

Commit

Permalink
ci: Ensure we always check for latest version of Go (#4703)
Browse files Browse the repository at this point in the history
* ci: Ensure we always check for latest version of Go

* Try to force 1.18.1, 1.17.9

* Use includes for the actual go semver

* Use `~` for semver here, apparently

* Try to make tests still run on 1.18.0 for Mac, for now
  • Loading branch information
francislavoie committed Apr 13, 2022
1 parent 30b6d1f commit c3a82f5
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 5 deletions.
18 changes: 16 additions & 2 deletions .github/workflows/ci.yml
Expand Up @@ -21,10 +21,23 @@ jobs:
os: [ ubuntu-latest, macos-latest, windows-latest ]
go: [ '1.17', '1.18' ]

include:
# Set the minimum Go patch version for the given Go minor
# Usable via ${{ matrix.GO_SEMVER }}
- go: '1.17'
GO_SEMVER: '~1.17.9'

- go: '1.18'
GO_SEMVER: '~1.18.1'

# Go 1.18.1 isn't released yet for Mac as of Apr 13 2022
- go: '1.18'
os: 'macos-latest'
GO_SEMVER: '1.18.0'

This comment has been minimized.

Copy link
@mohammed90

This comment has been minimized.

Copy link
@francislavoie

francislavoie Apr 15, 2022

Author Member

Yeah, we can. They released it just hours later

This comment has been minimized.

Copy link
@emilylange

emilylange Apr 15, 2022

Member

actions/go-versions#53 got merged too, so most of the changes could be reverted I guess.
I personally like the more explicit pinning though 🙃


# Set some variables per OS, usable via ${{ matrix.VAR }}
# CADDY_BIN_PATH: the path to the compiled Caddy binary, for artifact publishing
# SUCCESS: the typical value for $? per OS (Windows/pwsh returns 'True')
include:
- os: ubuntu-latest
CADDY_BIN_PATH: ./cmd/caddy/caddy
SUCCESS: 0
Expand All @@ -43,7 +56,8 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go }}
go-version: ${{ matrix.GO_SEMVER }}
check-latest: true

- name: Checkout code
uses: actions/checkout@v3
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/cross-build.yml
Expand Up @@ -17,13 +17,21 @@ jobs:
matrix:
goos: ['android', 'linux', 'solaris', 'illumos', 'dragonfly', 'freebsd', 'openbsd', 'plan9', 'windows', 'darwin', 'netbsd']
go: [ '1.18' ]

include:
# Set the minimum Go patch version for the given Go minor
# Usable via ${{ matrix.GO_SEMVER }}
- go: '1.18'
GO_SEMVER: '~1.18.1'

runs-on: ubuntu-latest
continue-on-error: true
steps:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go }}
go-version: ${{ matrix.GO_SEMVER }}
check-latest: true

- name: Print Go version and environment
id: vars
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/lint.yml
Expand Up @@ -19,7 +19,8 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: 1.17
go-version: '~1.17.9'
check-latest: true

- name: golangci-lint
uses: golangci/golangci-lint-action@v3
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/release.yml
Expand Up @@ -12,13 +12,21 @@ jobs:
matrix:
os: [ ubuntu-latest ]
go: [ '1.18' ]

include:
# Set the minimum Go patch version for the given Go minor
# Usable via ${{ matrix.GO_SEMVER }}
- go: '1.17'
GO_SEMVER: '~1.18.1'

runs-on: ${{ matrix.os }}

steps:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go }}
go-version: ${{ matrix.GO_SEMVER }}
check-latest: true

- name: Checkout code
uses: actions/checkout@v3
Expand Down

0 comments on commit c3a82f5

Please sign in to comment.