Skip to content

Commit

Permalink
rewrite: Add method Caddyfile directive (#4528)
Browse files Browse the repository at this point in the history
  • Loading branch information
francislavoie committed Jan 18, 2022
1 parent 6e6ce2b commit bcb7a19
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 1 deletion.
3 changes: 2 additions & 1 deletion caddyconfig/httpcaddyfile/directives.go
Expand Up @@ -45,7 +45,8 @@ var directiveOrder = []string{

"redir",

// URI manipulation
// incoming request manipulation
"method",
"rewrite",
"uri",
"try_files",
Expand Down
27 changes: 27 additions & 0 deletions caddytest/integration/caddyfile_adapt/method_directive.txt
@@ -0,0 +1,27 @@
:8080 {
method FOO
}
----------
{
"apps": {
"http": {
"servers": {
"srv0": {
"listen": [
":8080"
],
"routes": [
{
"handle": [
{
"handler": "rewrite",
"method": "FOO"
}
]
}
]
}
}
}
}
}
19 changes: 19 additions & 0 deletions modules/caddyhttp/rewrite/caddyfile.go
Expand Up @@ -27,6 +27,7 @@ import (

func init() {
httpcaddyfile.RegisterHandlerDirective("rewrite", parseCaddyfileRewrite)
httpcaddyfile.RegisterHandlerDirective("method", parseCaddyfileMethod)
httpcaddyfile.RegisterHandlerDirective("uri", parseCaddyfileURI)
httpcaddyfile.RegisterDirective("handle_path", parseCaddyfileHandlePath)
}
Expand All @@ -51,6 +52,24 @@ func parseCaddyfileRewrite(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler,
return rewr, nil
}

// parseCaddyfileMethod sets up a basic method rewrite handler from Caddyfile tokens. Syntax:
//
// method [<matcher>] <method>
//
func parseCaddyfileMethod(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler, error) {
var rewr Rewrite
for h.Next() {
if !h.NextArg() {
return nil, h.ArgErr()
}
rewr.Method = h.Val()
if h.NextArg() {
return nil, h.ArgErr()
}
}
return rewr, nil
}

// parseCaddyfileURI sets up a handler for manipulating (but not "rewriting") the
// URI from Caddyfile tokens. Syntax:
//
Expand Down

0 comments on commit bcb7a19

Please sign in to comment.