Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-nix.sh: Collapse log messages #139

Merged
merged 1 commit into from Jul 13, 2022

Conversation

sigprof
Copy link
Contributor

@sigprof sigprof commented Jun 26, 2022

The Nix installer produces a significant number of log messages, but usually those messages are not really interesting. Group those messages under a header, so that GitHub will keep them collapsed by default.

Usually log messages are collapsed under the step title anyway, but if this action is uses inside another composite action, there is no separate step title, therefore the whole Nix installer output is immediately visible when the log section for the outer composite action is expanded. Adding the group header fixes this problem.

This should also help with complaints like #126.


An example of how the log output looks when cachix/install-nix-action is used inside a composite action (expand the “Build” step):

(sorry, that's a very dirty testing repo).

The Nix installer produces a significant number of log messages, but
usually those messages are not really interesting.  Group those messages
under a header, so that GitHub will keep them collapsed by default.

(Usually log messages are collapsed under the step title anyway, but if
this action is uses inside another composite action, there is no
separate step title, therefore the whole Nix installer output is
immediately visible when the log section for the outer composite action
is expanded.  Adding the group header fixes this problem.)
@domenkozar domenkozar merged commit 92d3622 into cachix:master Jul 13, 2022
@sigprof sigprof deleted the collapse-log-output branch June 16, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants