Fix some more pycharm warnings (in test code). #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't use `input` as a variable/argument name, as it's a builtin symbol * Fix some type hints * Fix some unused arguments (when required to be present, prefix the arguments with underscore). * Fix some grammar errors * Fix lines which are too long * Fix regex pattern to match literal parentheses
caarmen
force-pushed
the
fix-pycharm-warnings-tests
branch
from
ed03299
to
97619f1
Compare
See FactoryBoy/factory_boy#468 PIDD: Pycharm inspection driven development 🤷
caarmen
force-pushed
the
fix-pycharm-warnings-tests
branch
from
f78f8e7
to
6e7596d
Compare
…ry boy factory instance. This field is documented.
caarmen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inputas a variable/argument name, as it's a builtin symbolxyz_factory.create()instead ofxyz_factory().